Hi Juergen,

On 30/05/2023 10:13, Juergen Gross wrote:
@@ -395,18 +393,18 @@ static int finalize_transaction(struct connection *conn,
while ((i = list_top(&trans->accessed, struct accessed_node, list))) {
                if (i->ta_node) {
-                       set_tdb_key(i->trans_name, &ta_key);
-                       data = tdb_fetch(tdb_ctx, ta_key);
+                       set_tdb_key(i->trans_name, &key);
+                       data = tdb_fetch(tdb_ctx, key);

This change confused me because you are just renaming the key variable. This feels unrelated to this patch (yes, I know that the variable 'key' is not used anymore). So I would rather prefer if you don't change the name.

Cheers,

--
Julien Grall

Reply via email to