Hi Julien, > -----Original Message----- > Subject: [PATCH 9/9] xen/arm32: vfp: Add missing U for shifted constant > > From: Julien Grall <jgr...@amazon.com> > > When enabling UBSAN on arm32, the following splat will be printed: > > (XEN) > ================================================================ > ================ > (XEN) UBSAN: Undefined behaviour in arch/arm/arm32/vfp.c:75:22 > (XEN) left shift of 255 by 24 places cannot be represented in type 'int' > > This is referring to the shift in FPSID_IMPLEMENTER_MASK. While we could > only add the U to the value shift there, it would be better to be > consistent and also add it for every value shifted. > > This should also addressing MISRA Rule 7.2: > > A "u" or "U" suffix shall be applied to all integer constants that > are represented in an unsigned type > > Signed-off-by: Julien Grall <jgr...@amazon.com>
Reviewed-by: Henry Wang <henry.w...@arm.com> Kind regards, Henry
