Re: [PATCH v3 1/7] swiotlb: make io_tlb_default_mem local to swiotlb.c

[Greg Kroah-Hartman]

On Tue, Jun 27, 2023 at 11:54:23AM +0200, Petr Tesarik wrote:
> +/**
> + * is_swiotlb_active() - check if the software IO TLB is initialized
> + * @dev:     Device to check, or %NULL for the default IO TLB.
> + */
>  bool is_swiotlb_active(struct device *dev)
>  {
> -     struct io_tlb_mem *mem = dev->dma_io_tlb_mem;
> +     struct io_tlb_mem *mem = dev
> +             ? dev->dma_io_tlb_mem
> +             : &io_tlb_default_mem;

That's impossible to read and maintain over time, sorry.

Please use real "if () else" lines, so that it can be maintained over
time.

thanks,

greg k-h