On Tue, Jun 27, 2023 at 08:56:18AM +0100, Andrew Cooper wrote:
> Xen uses the stdint types. Rearrange the types headers to define the
> compatibility __{u,s}$N types in terms of the stdint types, not the other way
> around.
>
> All all supported compilers on architectures other than x86 support the stdint
Duplicated "all".
> diff --git a/xen/include/xen/stdint.h b/xen/include/xen/stdint.h
> new file mode 100644
> index 000000000000..4cf82790f196
> --- /dev/null
> +++ b/xen/include/xen/stdint.h
> @@ -0,0 +1,33 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef __XEN_STDINT_H__
> +#define __XEN_STDINT_H__
> +
> +#ifndef __INT8_TYPE__ /* GCC <= 4.4 */
I'm possibly confused, but don't you want to use __INT8_TYPE__ if it's
defined, and hence this should be an ifdef instead of an ifndef?
> +
> +typedef __INT8_TYPE__ int8_t;
> +typedef __UINT8_TYPE__ uint8_t;
> +typedef __INT16_TYPE__ int16_t;
> +typedef __UINT16_TYPE__ uint16_t;
> +typedef __INT32_TYPE__ int32_t;
> +typedef __UINT32_TYPE__ uint32_t;
> +typedef __INT64_TYPE__ int64_t;
> +typedef __UINT64_TYPE__ uint64_t;
Thanks, Roger.
