On Wed, Jun 07, 2023 at 12:07:54PM +0200, Jan Beulich wrote:
> On 01.06.2023 15:05, Roger Pau Monne wrote:
> > --- a/docs/misc/xen-command-line.pandoc
> > +++ b/docs/misc/xen-command-line.pandoc
> > @@ -2628,6 +2628,9 @@ with the specified width, height and depth.
> > `ask` option. (N.B menu modes are displayed in hex, so `<mode>`
> > should be a hexadecimal number)
> >
> > +Note that all the occurrences of the vga option in the command line are
> > parsed,
> > +and hence later occurrences can overwrite selections done by prior ones.
>
> I'm not a native speaker, but is it perhaps more "override" that you
> mean?
TBH I always get confused with overwrite vs override. I will remove
the line as requested by Andrew.
> > --- a/xen/arch/x86/boot/cmdline.c
> > +++ b/xen/arch/x86/boot/cmdline.c
> > @@ -277,59 +277,58 @@ static u16 rows2vmode(unsigned int rows)
> >
> > static void vga_parse(const char *cmdline, early_boot_opts_t *ebo)
> > {
> > - const char *c;
> > - unsigned int tmp, vesa_depth, vesa_height, vesa_width;
> > -
> > - c = find_opt(cmdline, "vga=", true);
> > -
> > - if ( !c )
> > - return;
> > + const char *c = cmdline;
> >
> > - ebo->boot_vid_mode = ASK_VGA;
>
> I think this needs to stay here along with the addition of the related
> "else if" below. Otherwise I expect behavior for e.g. a sole "vga=keep"
> on the command line would change (in no longer prompting for the mode
> to use).
Done.
Thanks, Roger.
