On 29.06.2023 21:31, Stefano Stabellini wrote: > On Thu, 29 Jun 2023, Federico Serafini wrote: >> Change parameter name from 's' to 'state' in function definitions in >> order to: >> 1) keep consistency with the parameter names used in the corresponding >> declarations; >> 2) keep consistency with parameter names used within x86_emulate.h; >> 3) fix violations of MISRA C:2012 Rule 8.3. >> >> Signed-off-by: Federico Serafini <federico.seraf...@bugseng.com> > > You could use x86emul: as tag in the title. I'll let Jan choose the tag > he prefers.
x86emul: or x86/emul: is what we commonly use. That said, I don't like this change. The files touched are pretty new, and it was deliberate that I used s, not state, for the names. This is shorthand much like (globally) we use v (instead of vcpu) and d (instead of domain). Jan
