On 06.07.2023 00:52, Stefano Stabellini wrote: > On Wed, 5 Jul 2023, Stefano Stabellini wrote: >> On Tue, 4 Jul 2023, Jan Beulich wrote: >>> On 29.06.2023 17:55, Federico Serafini wrote: >>>> --- a/xen/arch/x86/cpu/mcheck/mce.h >>>> +++ b/xen/arch/x86/cpu/mcheck/mce.h >>>> @@ -44,7 +44,7 @@ extern uint8_t cmci_apic_vector; >>>> extern bool lmce_support; >>>> >>>> /* Init functions */ >>>> -enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *c); >>>> +enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *ci); >>> >>> Supported even by ... >>> >>>> enum mcheck_type intel_mcheck_init(struct cpuinfo_x86 *c, bool bsp); >>> >>> ... immediate context, c is the name we use for parameters of this type. >>> You want to change the definition in such cases instead of the >>> declaration. > > I should add that if we are going to change some functions in the other > direction then it would be best to move those changes in a separate > patch to make it easier to review.
+1 Jan
