On 05.07.2023 17:26, Simone Ballarin wrote: > --- a/xen/drivers/vpci/msi.c > +++ b/xen/drivers/vpci/msi.c > @@ -124,7 +124,7 @@ static void cf_check address_hi_write( > struct vpci_msi *msi = data; > > /* Clear and update high part. */ > - msi->address &= 0xffffffff; > + msi->address &= 0xffffffffU; > msi->address |= (uint64_t)val << 32;
Along the lines of the comment to an earlier patch and considering that a cast to uint64_t is already present here, I again wonder whether switching to casting to uint32_t wouldn't be the better change. > --- a/xen/drivers/vpci/msix.c > +++ b/xen/drivers/vpci/msix.c > @@ -531,7 +531,7 @@ static int cf_check msix_write( > > case PCI_MSIX_ENTRY_UPPER_ADDR_OFFSET: > entry->updated = true; > - entry->addr &= 0xffffffff; > + entry->addr &= 0xffffffffU; > entry->addr |= (uint64_t)data << 32; > break; Same here then. Jan
