On 19.07.2023 12:38, Federico Serafini wrote: > On 19/07/23 12:23, Andrew Cooper wrote: >> On 19/07/2023 11:07 am, Federico Serafini wrote: >>> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c >>> index 57363c2ae1..8f19a79f6f 100644 >>> --- a/xen/arch/x86/hvm/hvm.c >>> +++ b/xen/arch/x86/hvm/hvm.c >>> @@ -319,7 +319,7 @@ static bool pat_valid(uint64_t val) >>> return !(any_gt_7 | any_2_or_3); >>> } >>> >>> -int hvm_set_guest_pat(struct vcpu *v, uint64_t guest_pat) >>> +int hvm_set_guest_pat(struct vcpu *v, u64 guest_pat) >> >> If there's a u64 vs uint64_t mismatch (or others for that matter), >> resolve in the way of the stdint types. That way you're correcting in >> the direction of the Xen coding style, rather than away from it. > > Changing the type in the declaration from u64 to uint64_t > touching hvm.h will lead to inconsistencies with adjacent declarations. > In such cases, should I propagate the change to the adjacent ones > as well?
Preferably yes, I would say, but I wouldn't make this a hard requirement. The decls have a pretty bad mix anyway. One thing though: You also fiddle with hvm_get_guest_tsc_fixed(), and there please also convert the return type then. Jan
