On 21.07.2023 17:29, Nicola Vetrini wrote: > --- a/xen/common/spinlock.c > +++ b/xen/common/spinlock.c > @@ -78,7 +78,7 @@ static int __init cf_check lockdebug_init(void) > } > presmp_initcall(lockdebug_init); > > -void check_lock(union lock_debug *debug, bool try) > +void check_lock(union lock_debug *dbg, bool try)
I consider it reasonably likely that something named "dbg" might also appear, when we already have something with as generic a named as "debug". How about naming these parameters "ld", "ldbg", "lkdbg", or yet something along these lines, but (at least slightly) less generic? Another alternative would be to rename debug() to entry_DB(), along the lines of entry_CP(). Andrew, didn't you once propose renaming all the exception entry points like this? Jan
