Hello Stefano,
On 25/07/23 00:55, Stefano Stabellini wrote:
int request_irq(unsigned int irq, unsigned int irqflags,
- void (*handler)(int, void *, struct cpu_user_regs *),
+ void (*handler)(int irq, void *dev_id,
+ struct cpu_user_regs *regs),
We have an inconsistency where the handler functions on x86 typically
call it void *data, while on arm they typically use void *dev_id
(see xen/arch/x86/irq.c:request_irq and
xen/arch/x86/hpet.c:hpet_interrupt_handler). I think we should be
consistent. Or, if this is not a MISRA requirement because this is just
a function pointer rather than a proper function, then I would leave it
alone.
This is an inconsistency but it is not a violation of the rule 8.3.
Regards
--
Federico Serafini, M.Sc.
Software Engineer, BUGSENG (http://bugseng.com)
