Hi Julien,
On 21/07/2023 17:54, Julien Grall wrote:
Hi,
On 21/07/2023 16:22, Nicola Vetrini wrote:
Rule 5.3 has the following headline:
"An identifier declared in an inner scope shall not hide an
identifier declared in an outer scope"
The function parameters renamed in this patch are hiding a variable
defined
in an enclosing scope or a function identifier.
The following renames have been made:
- s/guest_mode/guest_mode_on/ to distinguish from function
'guest_mode'
- s/struct module_name/struct module_info to distinguish from the
homonymous
Typo: Missing '/' after 'module_info'.
parameters, since the structure contains more information than just
the name.
- s/file_name/file_info in 'xen/arch/arm/efi/efi-boot.h' for
consistency with
Same here.
the previous renaming.
Signed-off-by: Nicola Vetrini <[email protected]>
Assuming there is no other comments, I would be Ok to fix it on commit.
So:
Acked-by: Julien Grall <[email protected]>
Cheers,
I don't see any further comments on this. Are you ok with committing it?
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
