On 31.07.2023 09:33, Nicola Vetrini wrote: > The local variable 'p2mt' shadows a declaration of the same variable > in the enclosing scope, but removing the inner declaration > does not alter the semantics ('p2mt' is an output for the get_gfn > call later on) and this resolves a violation of > MISRA C:2012 Rule 5.3. > > Both variables were last introduced by commit > d4f699a0df6cea907c1de5c277500b98c0729685.
No, that commit moved the function (without correcting the issue, perhaps because of not noticing it, but perhaps also intentionally). > No functional changes. > > Signed-off-by: Nicola Vetrini <nicola.vetr...@bugseng.com> With the misleading part of the description either dropped (which I'd be okay doing while committing) or made meaningful: Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan