On 31/07/2023 16:01, Julien Grall wrote:
Hi,
On 31/07/2023 14:35, Nicola Vetrini wrote:
Rule 5.3 has the following headline:
"An identifier declared in an inner scope shall not hide an
identifier declared in an outer scope"
The parameter 'fdt' in static function within this file is removed,
as they served no purpose and shadowed the homonymous variable.
I am not convinced this is a good idea to keep 'fdt' as static
variable around because the name is too generic. Also in the future we
may be able to remove the global static variable.
This means that most of this patch will be reverted.
So as I wrote on Matrix, I would rather prefer if the global variable
is renamed to 'fdt_efi'.
Cheers,
Will do. Changing the parameters seemed less messy, but I'm fine either
way, so
I'll submit a v2 with that rename.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
