On 02.08.2023 00:54, Shawn Anastasio wrote: > On 8/1/23 6:19 AM, Jan Beulich wrote: >> On 28.07.2023 23:35, Shawn Anastasio wrote: >>> +static void opal_putchar(char c) >> >> Can't this be __init? > > Unlike OpenFirmware, OPAL calls are expected to be used by the OS during > its entire lifecycle, not just during early boot, so the full > (non-early) serial console driver would likely want to use these > functions as well.
Well, in the present usage it's unneeded post-init afaict. Hence if you don't want to add __init until another use appears, please add a respective remark in the description. Jan
