On 01.08.2023 23:02, Julien Grall wrote: > Hi, > > Title: This patch is not arm32 specific anymore. So I would replace > 'arm32' with 'arm'. This can be done on commit. > > On 01/08/2023 18:49, Khem Raj wrote: >> Assembler from binutils 2.41 rejects [1] this syntax >> >> .section "name"[, flags...] >> >> where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2] >> >> It is almost like a regression compared to 2.40 or older release, > > The next word after ',' start with an uppercase. Did you intend to use > '.' rather than ','? > > That said, the documentation has the following: > > For SPARC ELF targets, the assembler supports another type of .section > directive for compatibility with the Solaris assembler:"
But note that "SPARC" was added there only by the commit introducing the perceived regression. Jan > This leads me to think this is not a regression and instead an intended > behavior (even though it breaks older build) even it breaks build. > > I would suggest to reword the commit message to: > > " > Assembler from binutiles 2.41 will rejects ([1], [2]) the following syntax > > .section "name", #alloc > > for any other any target other than ELF SPARC. This means we can't use > it in the Arm code. > > So switch to the GNU syntax > > .section name [, "flags"[, @type]] > > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=11601 > [2] https://sourceware.org/binutils/docs-2.41/as.html#Section > > If you agree with the commit message, I can update it while committing. > > We should also consider to backport. > > Cheers, >
