On 04.08.2023 11:29, Andrew Cooper wrote:
> On 04/08/2023 8:23 am, Jan Beulich wrote:
>> On 03.08.2023 22:36, Andrew Cooper wrote:
>>> The opensuse-tumbleweed build jobs currently fail with:
>>>
>>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c: In
>>> function 'rsa_private':
>>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:56:7:
>>> error: the comparison will always evaluate as 'true' for the address of 'p'
>>> will never be NULL [-Werror=address]
>>> 56 | if (!key->p || !key->q || !key->u) {
>>> | ^
>>> In file included from
>>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:17:
>>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.h:28:12:
>>> note: 'p' declared here
>>> 28 | tpm_bn_t p;
>>> | ^
>>>
>>> This is because all tpm_bn_t's are 1-element arrays (of either a GMP or
>>> OpenSSL BIGNUM flavour). The author was probably meaning to do value
>>> checks,
>>> but that's not what the code does.
>> Looking at the code, I'm not sure about this. There could as well have been
>> the intention to allow pointers there, then permitting them to be left at
>> NULL. Who knows where that code came from originally.
>
> Do you agree that the patch is no function change, or are you saying
> that you think I got some of my analysis wrong?
Oh, I'm sorry for the potentially ambiguous reply: I agree there's no functional
change. I'm merely not sure about your guessing of value checks being meant.
Jan
