On 04.08.2023 17:27, Nicola Vetrini wrote: > --- a/xen/include/xen/delay.h > +++ b/xen/include/xen/delay.h > @@ -5,6 +5,6 @@ > > #include <asm/delay.h> > #define mdelay(n) (\ > - {unsigned long msec=(n); while (msec--) udelay(1000);}) > + {unsigned long msec_=(n); while (msec_--) udelay(1000);})
As elsewhere, please also adjust style while touching the line, at least as far as the obviously wrong case goes: #define mdelay(n) (\ {unsigned long msec_ = (n); while (msec_--) udelay(1000);}) Even better would be #define mdelay(n) ({ \ unsigned long msec_ = (n); while (msec_--) udelay(1000); \ }) or some such. I can take care of this while committing. Jan