Hi Julien, > On 11 Aug 2023, at 19:14, Julien Grall <jul...@xen.org> wrote: > > Hi Luca, > > On IRC, you suggest to skip the review for the patches moving out some code. > However, I still have one remark. > > On 08/08/2023 09:00, Luca Fancellu wrote: >> Move static memory and static shared memory code in separate modules >> so that they are included only when the corresponding feature is >> enabled, doing that we modularise the features and we remove some >> ifdefs from the code to improve readability. >> Move process_shm_node function from bootfdt module and make it >> externally visible. >> The visibility of the functions allocate_static_memory and >> assign_static_memory_11 is changed during the move from the >> dom0less-build module to the static-memory module, now they are >> externally visible. >> A static inline helper called process_shm_chosen is introduced, it >> will call the process_shm function for the '/chosen' node, and will >> be used by the funciton construct_dom0 instead of using directly >> process_shm, allowing some #ifdef to be removed. >> No functional changes are intended. >> Signed-off-by: Luca Fancellu <luca.fance...@arm.com> >> --- >> xen/arch/arm/Makefile | 2 + >> xen/arch/arm/bootfdt.c | 161 +----- >> xen/arch/arm/dom0less-build.c | 646 +--------------------- > > This file was created in the previous patch but now you are moving out the > code again. Please try to move the code only once within the series to ease > the review.
Sure, in the next push I will do the moving to different modules in one patch. > > Cheers, > > -- > Julien Grall
