On 14.08.2023 09:56, Nicola Vetrini wrote: > On 14/08/2023 09:47, Jan Beulich wrote: >> On 11.08.2023 09:19, Nicola Vetrini wrote: >>> --- a/xen/drivers/video/vga.c >>> +++ b/xen/drivers/video/vga.c >>> @@ -9,6 +9,7 @@ >>> #include <xen/mm.h> >>> #include <xen/param.h> >>> #include <xen/vga.h> >>> +#include <xen/console.h> >> >> xen/vga.h, which you move the declarations to, is already included >> here. >> Why the need for xen/console.h? > > vga.c needs a declaration for fill_console_start_info, which is declared > in console.h, as > stated in the commit message (it could be clarified perhaps).
Ah, I see. It's not very fortunate mixing of two separate adjustments. But then I'm inclined to ask: When fill_console_start_info() is defined in vga.c, wouldn't it make sense to move its declaration to vga.h? The more considering the type of its parameter? Jan
