On 17.08.2023 02:39, Vikram Garhwal wrote: > --- /dev/null > +++ b/xen/include/xen/iommu-private.h
I don't think private headers should live in include/xen/. Judging from only the patches I was Cc-ed on, ... > @@ -0,0 +1,28 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * xen/iommu-private.h > + */ > +#ifndef __XEN_IOMMU_PRIVATE_H__ > +#define __XEN_IOMMU_PRIVATE_H__ > + > +#ifdef CONFIG_HAS_DEVICE_TREE > +#include <xen/device_tree.h> > + > +/* > + * Checks if dt_device_node is assigned to a domain or not. This function > + * expects to be called with dtdevs_lock acquired by caller. > + */ > +bool_t iommu_dt_device_is_assigned_locked(const struct dt_device_node *dev); > +#endif ... I don't even see the need for the declaration, as the function is used only from the file also defining it. But of course if there is a use elsewhere (in Arm-only code, as is suggested by the description here), then the header (under a suitable name) wants to live under drivers/passthrough/ (and of course be included only from anywhere in that sub-tree). Jan
