Re: [PATCH] libxc: remove / adjust xc_get_cpufreq_para()'s BUILD_BUG_ON()s

[Juergen Gross]

On 23.08.23 16:07, Jan Beulich wrote:

On 23.08.2023 15:57, Jason Andryuk wrote:

On Wed, Aug 23, 2023 at 9:47 AM Jan Beulich <jbeul...@suse.com> wrote:

@@ -316,6 +277,22 @@ int xc_get_cpufreq_para(xc_interface *xc
          BUILD_BUG_ON(sizeof(((struct xc_get_cpufreq_para *)0)->u) !=
                      sizeof(((struct xen_get_cpufreq_para *)0)->u));

This check...

+        /* Sanity check layout of the union subject to memcpy() below. */
+        BUILD_BUG_ON(sizeof(user_para->u) != sizeof(sys_para->u));

And this check are the same?  Your newer one is nicer, so maybe drop the first?

Oh, indeed. Will do (and Jürgen, I'll assume this won't invalidate your
R-b).

Correct.


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

OpenPGP_signature.asc
Description: OpenPGP digital signature