On 25.08.2023 17:02, Nicola Vetrini wrote: > The common header file for ioreq should include the arch-specific one.
To be honest I'm not convinced of "should" here. There are two aspects to consider: On one hand it is good practice to do what you say. Otoh it introduces a needless dependency, and it'll require new arch-es (RISC-V, PPC at present) to introduce another dummy header just to satisfy the xen/ioreq.h use in common/memory.c. Therefore, _if_ we want to go this route, besides a wording change here I think ... > --- a/xen/include/xen/ioreq.h > +++ b/xen/include/xen/ioreq.h > @@ -20,6 +20,7 @@ > #define __XEN_IOREQ_H__ > > #include <xen/sched.h> > +#include <asm/ioreq.h> ... this #include wants to be conditional upon CONFIG_IOREQ_SERVER being defined. (I'm actually surprised that there's no respective #ifdef in that header, meaning types defined there are available even when the functionality was turned off.) Jan
