On 23.08.2023 22:07, Shawn Anastasio wrote: > +/* irq.c */ > + > +struct pirq *alloc_pirq_struct(struct domain *d) > +{ > + BUG_ON("unimplemented"); > +} > + > +int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, int will_share) > +{ > + BUG_ON("unimplemented"); > +} > + > +void pirq_guest_unbind(struct domain *d, struct pirq *pirq) > +{ > + BUG_ON("unimplemented"); > +} > + > +void pirq_set_affinity(struct domain *d, int pirq, const cpumask_t *mask) > +{ > + BUG_ON("unimplemented"); > +} > + > +static void ack_none(struct irq_desc *irq) > +{ > + BUG_ON("unimplemented"); > +} > + > +hw_irq_controller no_irq_type = { > + .typename = "none", > + .startup = irq_startup_none, > + .shutdown = irq_shutdown_none, > + .enable = irq_enable_none, > + .disable = irq_disable_none, > + .ack = ack_none, > +};
As said before, I think no new function should be introduced to fill any of the hook pointers. I.e. I would suggest to also drop ack_none(). But in the end it's your call of course. Either way Acked-by: Jan Beulich <jbeul...@suse.com> Jan