Hi Jan,
> On 1 Sep 2023, at 09:26, Jan Beulich <[email protected]> wrote:
>
> This using a GNU extension, it may not be exposed in general, just like
Nit: Missing "is"
> is done on x86. External consumers need to make this type available up
> front (just like we expect {,u}int<N>_t to be supplied) - unlike on x86
> the type is actually needed outside of tools-only interfaces, because
> guest handle definitions use it.
>
> While there also add underscores around "aligned".
>
> Signed-off-by: Jan Beulich <[email protected]>
With the Nit fixed (can be done on commit):
Reviewed-by: Bertrand Marquis <[email protected]>
Cheers
Bertrand
>
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -152,8 +152,10 @@
>
> #define XEN_HYPERCALL_TAG 0XEA1
>
> -#define int64_aligned_t int64_t __attribute__((aligned(8)))
> -#define uint64_aligned_t uint64_t __attribute__((aligned(8)))
> +#if defined(__XEN__) || defined(__XEN_TOOLS__)
> +#define int64_aligned_t int64_t __attribute__((__aligned__(8)))
> +#define uint64_aligned_t uint64_t __attribute__((__aligned__(8)))
> +#endif
>
> #ifndef __ASSEMBLY__
> #define ___DEFINE_XEN_GUEST_HANDLE(name, type) \
