Hi Michal, On Mon, Sep 04, 2023 at 12:38:01PM +0200, Michal Orzel wrote: > > > On 01/09/2023 06:59, Vikram Garhwal wrote: > > Add remove_device callback for removing the device entry from smmu-master > > using > > following steps: > > 1. Find if SMMU master exists for the device node. > > 2. Check if device is currently in use. > Just like in v10: you are not checking it. I asked you to add a check > following Julien suggestion > but you did not reply to it. Even if you do not want to add this extra layer > of protection, you > should mention that you rely on a check in iommu_remove_dt_device() instead. > You can wait for Stefano > to give his opinion (and possibly ack this patch as is). > Caller checks it already so that was the reason for not adding here. IIUC, Stefano was okay with v10 patch so that's why i didn't make changes.
> ~Michal
