On 07.09.2023 15:45, Oleksii wrote: > On Thu, 2023-09-07 at 12:48 +0200, Jan Beulich wrote: >> On 07.09.2023 11:32, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/scripts/Makefile.asm-generic >>> @@ -0,0 +1,53 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only >>> +# include/asm-generic contains a lot of files that are used >>> +# verbatim by several architectures. >>> +# >>> +# This Makefile reads the file >>> arch/$(SRCARCH)/include/asm/Makefile >>> +# and for each file listed in this file with generic-y creates >>> +# a small wrapper file in arch/$(SRCARCH)/include/generated/asm. >>> + >>> +PHONY := all >>> +all: >>> + >>> +src := $(subst /generated,,$(obj)) >>> + >>> +include $(srctree)/scripts/Kbuild.include >>> +-include $(src)/Makefile >> >> With the definition of src above, is this correct for out-of-tree >> builds? > Logically you are right and I think it would be better to use > $(srctree)/$src but it works for out-of-tree builds too. > > $ CONTAINER_NO_PULL=1 CONTAINER=riscv64 > ./automation/scripts/containerize make O=xen-build V=2 > XEN_TARGET_ARCH=riscv64 -C xen build > > $ ls -la xen/xen-build/arch/riscv/include/generated/asm/vm_event.h > -rw-r--r--. 1 ok ok 34 вер 7 16:27 xen/xen- > build/arch/riscv/include/generated/asm/vm_event.h
Oh, right, aiui because of VPATH being set to $(srctree), and therefore in the absence of a Makefile in $(objtree)/$(src)/ it'll go look for one in $(srctree)/$(src)/. Never mind then: Acked-by: Jan Beulich <[email protected]> Jan
