On 12.09.2023 17:39, Simone Ballarin wrote: > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > headline states: > "A 'u' or 'U' suffix shall be applied to all integer constants > that are represented in an unsigned type". > > Add the 'U' suffix to integers literals with unsigned type. > Use _AC() for macro costants that are used also in assembly files. > > For the sake of uniformity, the following changes are made: > - add the 'U' suffix to macros in 'pci.h' > - use _AC() for macros near 'X86_CR0_PG' > > Signed-off-by: Simone Ballarin <simone.balla...@bugseng.com> > Signed-off-by: Gianluca Luparini <gianluca.lupar...@bugseng.com>
Changes look okay, but same comment as for patch 2 as to tags (which apparently applies to the entire series). Plus "x86/asm:" is imo pretty misleading in the title - you're not changing any assembly code. "x86/include:" would seem more applicable to me. Jan
