Hi, > On Sep 21, 2023, at 20:38, Jan Beulich <[email protected]> wrote: > On 20.09.2023 21:21, Andrew Cooper wrote: >> Nicola reports that the XSA-438 fix introduced new MISRA violations because >> of >> some incidental tidying it tried to do. The parameter is useless, so resolve >> the MISRA regression by removing it. >> >> hap_update_cr3() discards the parameter entirely, while sh_update_cr3() uses >> it to distinguish internal and external callers and therefore whether the >> paging lock should be taken. >> >> However, we have paging_lock_recursive() for this purpose, which also avoids >> the ability for the shadow internal callers to accidentally not hold the >> lock. >> >> Fixes: fb0ff49fe9f7 ("x86/shadow: defer releasing of PV's top-level shadow >> reference") >> Reported-by: Nicola Vetrini <[email protected]> >> Signed-off-by: Andrew Cooper <[email protected]> >> --- >> CC: Jan Beulich <[email protected]> >> CC: Roger Pau Monné <[email protected]> >> CC: Wei Liu <[email protected]> >> CC: George Dunlap <[email protected]> >> CC: Tim Deegan <[email protected]> >> CC: Stefano Stabellini <[email protected]> >> CC: Nicola Vetrini <[email protected]> >> >> Slightly RFC. Only compile tested so far. > > With shadow/none.c also suitably edited > Reviewed-by: Jan Beulich <[email protected]>
Release-acked-by: Henry Wang <[email protected]> Kind regards, Henry
