On 22.09.2023 17:19, Federico Serafini wrote:
> @@ -466,68 +461,7 @@ static int cf_check pit_load(struct domain *d,
> hvm_domain_context_t *h)
> HVM_REGISTER_SAVE_RESTORE(PIT, pit_save, pit_load, 1, HVMSR_PER_DOM);
> #endif
>
> -void pit_reset(struct domain *d)
> -{
> - PITState *pit = domain_vpit(d);
> - struct hvm_hw_pit_channel *s;
> - int i;
> -
> - if ( !has_vpit(d) )
> - return;
> -
> - if ( is_hvm_domain(d) )
> - {
> - TRACE_0D(TRC_HVM_EMUL_PIT_STOP_TIMER);
> - destroy_periodic_time(&pit->pt0);
> - pit->pt0.source = PTSRC_isa;
> - }
> -
> - spin_lock(&pit->lock);
> -
> - for ( i = 0; i < 3; i++ )
> - {
> - s = &pit->hw.channels[i];
> - s->mode = 0xff; /* the init mode */
> - s->gate = (i != 2);
> - pit_load_count(pit, i, 0);
> - }
> -
> - spin_unlock(&pit->lock);
> -}
> -
> -void pit_init(struct domain *d)
> -{
> - PITState *pit = domain_vpit(d);
> -
> - if ( !has_vpit(d) )
> - return;
> -
> - spin_lock_init(&pit->lock);
> -
> - if ( is_hvm_domain(d) )
> - {
> - register_portio_handler(d, PIT_BASE, 4, handle_pit_io);
> - register_portio_handler(d, 0x61, 1, handle_speaker_io);
> - }
> -
> - pit_reset(d);
> -}
> -
> -void pit_deinit(struct domain *d)
> -{
> - PITState *pit = domain_vpit(d);
> -
> - if ( !has_vpit(d) )
> - return;
> -
> - if ( is_hvm_domain(d) )
> - {
> - TRACE_0D(TRC_HVM_EMUL_PIT_STOP_TIMER);
> - destroy_periodic_time(&pit->pt0);
> - }
> -}
> -
> -/* the intercept action for PIT DM retval:0--not handled; 1--handled */
> +/* the intercept action for PIT DM retval:0--not handled; 1--handled */
If you already touch this comment to remove trailing whitespace, it also
wants its style corrected. Perhaps okay to do while committing, so then:
Acked-by: Jan Beulich <[email protected]>
Jan
