On Tue, Oct 03, 2023 at 09:46:13AM -0400, Tamas K Lengyel wrote: > On Mon, Oct 2, 2023 at 11:12 AM Roger Pau Monne <[email protected]> wrote: > > > > Instead let map_vcpu_info() and it's call to get_page_from_gfn() > > populate the page in the child as needed. Also remove the bogus > > copy_domain_page(): should be placed before the call to map_vcpu_info(), > > as the later can update the contents of the vcpu_info page. > > > > Note that this eliminates a bug in copy_vcpu_settings(): The function did > > allocate a new page regardless of the GFN already having a mapping, thus in > > particular breaking the case of two vCPU-s having their info areas on the > > same > > page. > > > > Fixes: 41548c5472a3 ('mem_sharing: VM forking') > > Signed-off-by: Roger Pau Monné <[email protected]> > > Acked-by: Tamas K Lengyel <[email protected]>
Thanks, Roger.
