Hi Julien, > On Oct 14, 2023, at 01:44, Julien Grall <[email protected]> wrote: > > Hi Henry, > > On 09/10/2023 02:03, Henry Wang wrote: >> diff --git a/xen/arch/arm/mmu/setup.c b/xen/arch/arm/mmu/setup.c >> index c2df976ab2..dff81f6125 100644 >> --- a/xen/arch/arm/mmu/setup.c >> +++ b/xen/arch/arm/mmu/setup.c >> @@ -339,6 +339,33 @@ void free_init_memory(void) >> printk("Freed %ldkB init memory.\n", >> (long)(__init_end-__init_begin)>>10); >> } >> +/** >> + * copy_from_paddr - copy data from a physical address >> + * @dst: destination virtual address >> + * @paddr: source physical address >> + * @len: length to copy >> + */ >> +void __init copy_from_paddr(void *dst, paddr_t paddr, unsigned long len) >> +{ >> + void *src = (void *)FIXMAP_ADDR(FIXMAP_MISC); >> + >> + while (len) { >> + unsigned long l, s; >> + >> + s = paddr & (PAGE_SIZE-1); > > NIT: I would take the opportunity to add a missing space before/after '-'.
Sounds good, I’ve done that in my local v8 and also mentioned this change in commit message as: ``` Take the opportunity to add a missing space before and after '-' in "s = paddr & (PAGE_SIZE-1);" of copy_from_paddr(). ``` > > Reviewed-by: Julien Grall <[email protected]> Thanks! Kind regards, Henry > > Cheers, > > -- > Julien Grall
