On 14/10/2023 00:34, Stefano Stabellini wrote:
On Fri, 13 Oct 2023, Stefano Stabellini wrote:
On Fri, 13 Oct 2023, Federico Serafini wrote:
Add missing parameter names, no functional change.
Signed-off-by: Federico Serafini <federico.seraf...@bugseng.com>
---
xen/arch/arm/include/asm/cpufeature.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/include/asm/cpufeature.h
b/xen/arch/arm/include/asm/cpufeature.h
index 8011076b8c..41e97c23dd 100644
--- a/xen/arch/arm/include/asm/cpufeature.h
+++ b/xen/arch/arm/include/asm/cpufeature.h
@@ -127,8 +127,8 @@ static inline void cpus_set_cap(unsigned int num)
struct arm_cpu_capabilities {
const char *desc;
u16 capability;
- bool (*matches)(const struct arm_cpu_capabilities *);
- int (*enable)(void *); /* Called on every active CPUs */
+ bool (*matches)(const struct arm_cpu_capabilities *caps);
all the implementations of matches I found in xen/arch/arm/cpuerrata.c
actually call the parameter "entry"
+ int (*enable)(void *ptr); /* Called on every active CPUs */
this one instead is "data"
I committed all the other patches in this series to the my for-4.19 branch
I have left some comments in patch #1. Given this is not the latest
master, I think we should consider to remove/replace the patch rather
than introducing a follow-up.
Cheers,
--
Julien Grall
