Hi Julien, > On 16 Oct 2023, at 11:07, Julien Grall <jul...@xen.org> wrote: > > Hi, > > On 13/10/2023 16:24, Federico Serafini wrote: >> Add missing parameter names, no functional change. >> Signed-off-by: Federico Serafini <federico.seraf...@bugseng.com> >> --- >> xen/drivers/passthrough/arm/smmu.c | 6 +++--- > > This file is using the Linux coding style because it is imported from Linux. > I was under the impression we would exclude such file for now. > > Looking at exclude-list.json, it doesn't seem to be present. I think this > patch should be replaced with adding a line in execlude-list.json.
I think that during one of the discussions we said that this file already deviated quite a lot from the status in Linux and we wanted to turn it to Xen coding style in the future hence it is not listed in the exclude file. At the end having a working smmu might be critical in a safety context so it will make sense to also check this part of xen. @Rahul: do you agree ? Cheers Bertrand > > Cheers, > > -- > Julien Grall
