On 13.10.2023 11:42, Juergen Gross wrote: > Fix some coding style issues in spinlock coding: > > - Instead of u64 etc. use the preferred uint64_t etc. types > - Remove some trailing spaces > - Add missing spaces in "if" statements > - Add some missing blank lines > > Signed-off-by: Juergen Gross <[email protected]>
Acked-by: Jan Beulich <[email protected]> with one possible further request: > @@ -298,7 +298,7 @@ static always_inline spinlock_tickets_t > observe_lock(spinlock_tickets_t *t) > return v; > } > > -static always_inline u16 observe_head(spinlock_tickets_t *t) > +static always_inline uint16_t observe_head(spinlock_tickets_t *t) While there, could you also add const to the pointed-to parameter type? t, after all, ... > { > smp_rmb(); > return read_atomic(&t->head); ... is only read through. (I'd also be happy for this to be adjusted on commit, so long as you agree.) Jan
