On 06/10/2023 3:05 am, Marek Marczykowski-Górecki wrote: > diff --git a/automation/scripts/qubes-x86-64.sh > b/automation/scripts/qubes-x86-64.sh > index 5464d10fc343..842e6fae7204 100755 > --- a/automation/scripts/qubes-x86-64.sh > +++ b/automation/scripts/qubes-x86-64.sh > @@ -90,23 +90,18 @@ on_reboot = "destroy" > > domU_check=" > set -x -e > -ip link set eth0 up > -timeout 30s udhcpc -i eth0 > +interface=eth0 > +ip link set \"\$interface\" up > +timeout 30s udhcpc -i \"\$interface\" > pingip=\$(ip -o -4 r show default|cut -f 3 -d ' ') > ping -c 10 \"\$pingip\" > echo domU started > -cat /proc/interrupts > +pcidevice=\$(basename \$(readlink /sys/class/net/\$interface/device)) > +lspci -vs \$pcidevice
Actually, I know I said I had no more comments, and maybe this is one for further cleanup rather than for now, but wouldn't we be much better using a heredoc? read -r -d '' domU_check <<"EOF" lorem ipsum, no \ escaping " or $ EOF If nothing else it would make the innards of the more readable as a script fragment, and less likely go to wrong with variable expansion in the wrong context. ~Andrew
