Hi,
> On Oct 19, 2023, at 02:00, Julien Grall <jul...@xen.org> wrote:
>
> Hi Jan,
>
> On 18/10/2023 15:58, Jan Beulich wrote:
>> From: Manuel Bouyer <bou...@antioche.eu.org>
>> The use of rcu_lock_domain_by_id() right in switch_serial_input() makes
>> assumptions about domain IDs which don't hold when in shim mode: The
>> sole (initial) domain there has a non-zero ID. Obtain the real domain ID
>> in that case (generalized as get_initial_domain_id() returns zero when
>> not in shim mode).
>> Note that console_input_domain() isn't altered, for not being used when
>> in shim mode (or more generally on x86).
>
> I think it would be worth to either add a comment in console_input_domain()
> and/or #ifdef the code. In any case...
>
>> Fixes: c2581c58bec9 ("xen/console: skip switching serial input to non
>> existing domains")
>> Signed-off-by: Manuel Bouyer <bou...@antioche.eu.org>
>> Signed-off-by: Jan Beulich <jbeul...@suse.com>
>
> ...
>
> Reviewed-by: Julien Grall <jgr...@amazon.com>
>
>
> Also, should we consider it for xen 4.18? (I notice there is no for-4.18 tag).
Yes, so:
Release-acked-by: Henry Wang <henry.w...@arm.com>
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
