The clauses of a switch should be enclosed directly by a switch statement to make the code more easily understandable and less prone to errors.
Signed-off-by: Nicola Vetrini <[email protected]> --- This patch is mainly indended to probe how the community, especially the maintainers, would receive such modifications to the code, and whether there would be consensus on the rule's adoption. Anyone is welcome to give feedback on this, especially on the x86 side, where this pattern is used more frequently. --- xen/arch/x86/hvm/vlapic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index c7ce82d0649a..318dd48577e2 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -1034,10 +1034,10 @@ int guest_wrmsr_x2apic(struct vcpu *v, uint32_t msr, uint64_t val) case APIC_EOI: case APIC_ESR: if ( val ) - { - default: return X86EMUL_EXCEPTION; - } + break; + default: + return X86EMUL_EXCEPTION; } vlapic_reg_write(v, array_index_nospec(offset, PAGE_SIZE), val); -- 2.34.1
