On 26.10.2023 19:38, Edwin Torok wrote: >> On 25 Oct 2023, at 15:04, Jan Beulich <[email protected]> wrote: >> On 25.10.2023 15:52, Edwin Török wrote: >>> --- a/tools/ocaml/Makefile.rules >>> +++ b/tools/ocaml/Makefile.rules >>> @@ -37,7 +37,7 @@ ALL_OCAML_OBJS ?= $(OBJS) >>> $(call quiet-command, $(OCAMLYACC) -q $<,MLYACC,$@) >>> >>> %.o: %.c >>> - $(call quiet-command, $(CC) $(CFLAGS) -c -o $@ $<,CC,$@) >>> + $(call quiet-command, $(OCAMLOPT) -verbose $(addprefix -ccopt ,$(CFLAGS)) >>> -c -o $@ $<,CC,$@) >> >> Wouldn't -verbose better be passed only if the build isn't a quiet one? > > Only the OCaml files (and the hypervisor itself) are compiled in quiet mode. > It looks like tools/ and the C files in tools/ocaml were not, > so the patch as is preserves the existing behaviour.
Yes and no. There's also make's -s flag, which I consider being wrongly overridden by passing -verbose here. But anyway ... Jan
