On 25.10.2023 21:29, Edwin Török wrote: > To more easily lookup the semantics of these MSRs add references to > vendor manuals.
As much as I appreciate the intention, ... > --- a/xen/arch/x86/include/asm/msr-index.h > +++ b/xen/arch/x86/include/asm/msr-index.h > @@ -13,6 +13,16 @@ > * Blocks of related constants should be sorted by MSR index. The constant > * names should be as concise as possible, and the bit names may have an > * abbreviated name. Exceptions will be considered on a case-by-case basis. > + * > + * References: > + * - > https://software.intel.com/content/www/us/en/develop/articles/intel-sdm.html > + * Intel(R) 64 and IA-32 architectures SDM volume 4: Model-specific > registers > + * Chapter 2, "Model-Specific Registers (MSRs)" ... at least Intel's URL has changed several times over the years. Volume and chapter numbers change even more frequently. Any such is liable to go stale at some point. Jan > + * - https://developer.amd.com/resources/developer-guides-manuals/ > + * AMD64 Architecture Programmer’s Manual Volume 2: System Programming > + * Appendix A "MSR Cross-Reference" > + * > */ > > #define MSR_P5_MC_ADDR 0
