On 20/11/2023 10:49 pm, Andrew Cooper wrote: > The codebase is now -Wwrite-strings clean. Activate the option to cause > string literals to have a const type, and prevent any violations of MISRA Rule > 7.4 being reintroduced. > > Signed-off-by: Andrew Cooper <[email protected]> > --- > CC: Jan Beulich <[email protected]> > CC: Roger Pau Monné <[email protected]> > CC: Wei Liu <[email protected]> > CC: Stefano Stabellini <[email protected]> > CC: Julien Grall <[email protected]> > CC: Volodymyr Babchuk <[email protected]> > CC: Bertrand Marquis <[email protected]> > CC: Michal Orzel <[email protected]> > CC: Roberto Bagnara <[email protected]> > CC: Nicola Vetrini <[email protected]> > --- > xen/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/Makefile b/xen/Makefile > index 7b869f4b3037..ca571103c868 100644 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -392,7 +392,7 @@ endif > CFLAGS-$(CONFIG_CC_SPLIT_SECTIONS) += -ffunction-sections -fdata-sections > > CFLAGS += -nostdinc -fno-builtin -fno-common > -CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith > +CFLAGS += -Werror -Wredundant-decls -Wwrite-strings -Wno-pointer-arith > $(call cc-option-add,CFLAGS,CC,-Wvla) > CFLAGS += -pipe -D__XEN__ -include $(srctree)/include/xen/config.h > CFLAGS-$(CONFIG_DEBUG_INFO) += -g
I meant to say. I've checked our minimum compiler versions, and -Wwrite-strings is supported by everything. ~Andrew
