Hi Jan Beulich,
On 2023/11/30 14:44, Chen, Jiqian wrote:
>
> On 2023/11/28 23:14, Jan Beulich wrote:
>> On 24.11.2023 11:41, Jiqian Chen wrote:
>>> --- a/xen/arch/x86/hvm/hypercall.c
>>> +++ b/xen/arch/x86/hvm/hypercall.c
>>> @@ -74,6 +74,8 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void)
>>> arg)
>>> {
>>> case PHYSDEVOP_map_pirq:
>>> case PHYSDEVOP_unmap_pirq:
>>> + if (is_hardware_domain(currd))
>>> + break;
>>> case PHYSDEVOP_eoi:
>>> case PHYSDEVOP_irq_status_query:
>>> case PHYSDEVOP_get_free_pirq:
>>
>> If you wouldn't go the route suggested by Roger, I think you will need
>> to deny self-mapping requests here.
> Do you mean below?
> if (arg.domid == DOMID_SELF)
> return;
>
>>
>> Also note that both here and in patch 1 you will want to adjust a number
>> of style violations.
> Could you please descript in detail? This will greatly assist me in making
> modifications in the next version. Thank you!
Oh! Do you mean there are many code style problems that not satisfiable for
CODING_STYLE of Xen in my codes?
Thank Xenia for reminder.
>
>>
>> Jan
>
--
Best regards,
Jiqian Chen.
