Hi Luca, On 30/11/2023 13:17, Luca Fancellu wrote:
On 30 Nov 2023, at 09:57, Michal Orzel <[email protected]> wrote:Move static event channel feature related code to a separate module (static-evtchn.{c,h}) in the spirit of fine granular configuration, so that the feature can be disabled if not needed. Introduce Kconfig option CONFIG_STATIC_EVTCHN, enabled by default (to keep the current behavior) dependent on CONFIG_DOM0LESS. While it could be possible to create a loopback connection for dom0 only, this use case does not really need this feature and all the docs and commit messages refer explicitly to the use in dom0less system. The only function visible externally is alloc_static_evtchn(), so move the prototype to static-evtchn.h and provide a stub in case a feature is disabled. Guard static_evtchn_created in struct dt_device_node as well as its helpers. Signed-off-by: Michal Orzel <[email protected]> ---Hi Michal, FWIW because it is already Ack-ed. Reviewed-by: Luca Fancellu <[email protected]>
Usually when I provide an Acked-by, it means I went through the code and generally happy with the patch, but I didn't review throroughly. Even if I provide a reviewed-by, it is always useful to have extra pair of eyes :). So thanks for looking at it!
It is now committed. Cheers,
-- Julien Grall
