On 04.12.2023 10:43, Roger Pau Monne wrote:
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -2136,6 +2136,54 @@ int __hwdom_init xen_in_range(unsigned long mfn)
> return 0;
> }
>
> +int __hwdom_init remove_xen_ranges(struct rangeset *r)
> +{
> + paddr_t start, end;
> + int rc;
> +
> + /* S3 resume code (and other real mode trampoline code) */
> + rc = rangeset_remove_range(r, PFN_DOWN(bootsym_phys(trampoline_start)),
> + PFN_DOWN(bootsym_phys(trampoline_end)));
> + if ( rc )
> + return rc;
> +
> + /*
> + * This needs to remain in sync with the uses of the same symbols in
> + * - __start_xen()
> + * - is_xen_fixed_mfn()
> + * - tboot_shutdown()
> + */
As you're duplicating this comment from xen_in_range(), you want to
- also mention xen_in_range() here,
- also update xen_in_range()'s comment,
- also update the respective comments in __start_xen() that also mention
xen_in_range().
Everything else here looks good to me.
Jan
