On 24.11.2023 11:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/include/public/arch-riscv/hvm/save.h > @@ -0,0 +1,20 @@ > +/* SPDX-License-Identifier: MIT */ > +/* > + * Structure definitions for HVM state that is held by Xen and must > + * be saved along with the domain's memory and device-model state. > + */ > + > +#ifndef __XEN_PUBLIC_HVM_SAVE_RISCV_H__ > +#define __XEN_PUBLIC_HVM_SAVE_RISCV_H__ > + > +#endif > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */
Seeing that Arm's is as empty, I wonder why we have it. Julien, Stefano? > --- a/xen/include/public/hvm/save.h > +++ b/xen/include/public/hvm/save.h > @@ -91,6 +91,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct hvm_save_end); > #include "../arch-arm/hvm/save.h" > #elif defined(__powerpc64__) > #include "../arch-ppc.h" > +#elif defined(__riscv) > +#include "../arch-riscv/hvm/save.h" > #else > #error "unsupported architecture" > #endif The PPC part here looks bogus altogether. Shawn? Jan