On 05.12.2023 18:29, Roger Pau Monné wrote:
> On Tue, Nov 28, 2023 at 11:35:46AM +0100, Jan Beulich wrote:
>> @@ -387,7 +387,7 @@ static int cf_check vpic_intercept_elcr_
>> if ( dir == IOREQ_WRITE )
>> {
>> /* Some IRs are always edge trig. Slave IR is always level
>> trig. */
>> - data = (*val >> shift) & vpic_elcr_mask(vpic);
>> + data = (*val >> shift) & vpic_elcr_mask(vpic, 1);
>
> Not that it matters much, but I think you could use
> vpic_elcr_mask(vpic, 0) to strictly keep the same behavior as
> before?
Indeed, as also said in the description. Personally I view it as (slightly)
more logical to not mask off ...
>> if ( vpic->is_master )
>> data |= 1 << 2;
>
> Since the bit is forcefully set here anyway.
... and then set the bit, hence why I chose to go with 1.
> Regardless:
>
> Reviewed-by: Roger Pau Monné <roger....@citrix.com>
Thanks.
Jan
