On 11/12/2023 5:07 pm, Anthony PERARD wrote:
> On Thu, Nov 23, 2023 at 04:30:23PM +0000, Andrew Cooper wrote:
>> This was declared deprecated in commit 10c88f1c18b7 ("tools: Install pv
>> bootloaders in libexec rather than /usr/bin") in 2012
> This commit only speak about wanting to deprecate the full path to
> `pygrub`, and calling something deprecated in a commit message alone
> isn't very friendly. But there's a better commit calling for the
> deprecation:
> c31d6a7ee2ea ("libxl: Warn that /usr/bin/pygrub is deprecated")
> even if it's only in a libxl log message at run time.
>
> I hope we have a better schema to deprecate things.Oh, I'd not even spotted that one. This patch was actually triggered by newer versions of RPM objecting to absolute symlinks. > >> Take it out fully now, 11 years later. >> >> Signed-off-by: Andrew Cooper <[email protected]> > Beside the commit message that could call for a better commit, patch > looks good: > Reviewed-by: Anthony PERARD <[email protected]> Thanks. I'll adjust the commit message. ~Andrew
