On 11.12.2023 20:40, Oleksii wrote: > On Mon, 2023-12-11 at 18:49 +0100, Jan Beulich wrote: >> On 11.12.2023 18:37, Oleksii wrote: >>> On Mon, 2023-12-11 at 17:02 +0100, Jan Beulich wrote: >>>> In which case the approach taken here may be fine, but >>>> it still wouldn't be what I suggested. It may then be Stefano or >>>> Andrew >>>> who you could consider for such a tag. >>> I'm a bit confused again. In this case, it seems that both you >>> andStefano or Andrew should be on the suggested list. >>> You proposed the approach with "#ifdef CONFIG_GRANT_TABLE #include >>> <asm/grant_table.h> #endif". >> >> But you're not meaning to use that approach anymore, are you? > No, I am going to use it because there is still a need to use #ifdef > for #include <asm/grant_table.h> in <xen/grant_table.h> to avoid > providing a useless empty asm/grant_table.h header if > CONFIG_GRANT_TABLE isn't supported.
Then _there_ keeping the tag is okay of course. But the CI change (or whatever is come of it) will need treating in whichever way it is going to move. Jan
