On 20/12/2023 9:51 pm, Julien Grall wrote: > Hi Andrew, > > On 20/12/2023 21:47, Andrew Cooper wrote: >> When in use, the spew: >> >> (XEN) Assertion '!memchr_inv(b->ptr.buffer + MIN_BLOCK_SIZE, >> POISON_BYTE, (b->size & BLOCK_SIZE_MASK) - MIN_BLOCK_SIZE)' failed at >> common/xmalloc_tlsf.c:246 >> >> is unweidly and likely meaningless to non-Xen developers. Therefore: >> >> * Switch to IS_ENABLED(). There's no need for full #ifdef-ary. >> * Pull memchr_inv() out into the if(), and provide an error message >> which >> clearly states that corruption has been found. >> >> Signed-off-by: Andrew Cooper <[email protected]> > > With one remark: > > Reviewed-by: Julien Grall <[email protected]>
Thanks. Will fix. ~Andrew
