>>> On 29.05.18 at 16:58, <aisa...@bitdefender.com> wrote: > This patch is focused on merging the *save() funcs to the *save_one() > funcs to remove redundancy. Also the for loop is moved to the caller so > now we can save info for a single vcpu instance. > > Signed-off-by: Alexandru Isaila <aisa...@bitdefender.com> > > --- > Changes since V4: > - Save funcs are deleted > - vcpu si added to the param list > - save_one funcs are now static > - Add blank line after "/* save mtrr&pat */" comment > --- > xen/arch/x86/cpu/mcheck/vmce.c | 28 ++-- > xen/arch/x86/hvm/hpet.c | 3 +- > xen/arch/x86/hvm/hvm.c | 287 > +++++++++++++++++------------------------ > xen/arch/x86/hvm/i8254.c | 3 +- > xen/arch/x86/hvm/irq.c | 9 +- > xen/arch/x86/hvm/mtrr.c | 36 ++---- > xen/arch/x86/hvm/pmtimer.c | 3 +- > xen/arch/x86/hvm/rtc.c | 3 +- > xen/arch/x86/hvm/save.c | 125 +++++++++++++----- > xen/arch/x86/hvm/vioapic.c | 3 +- > xen/arch/x86/hvm/viridian.c | 30 ++--- > xen/arch/x86/hvm/vlapic.c | 28 ++-- > xen/arch/x86/hvm/vpic.c | 3 +- > xen/include/asm-x86/hvm/save.h | 2 +- > 14 files changed, 271 insertions(+), 292 deletions(-)
Since I see you've already sent v6: This patch is still way too large for its subject. It should, as said before, in particular have no need to touch most of the files above. IOW - there's more splitting work to be done afaict. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel